sonic-net / sonic-buildimage
Code health
This codebase scores 8.9 out of 10 for code health, which we rate excellent. It also scores maintainability 8.9 and static performance 9.8 out of 10. The three are scored separately and never blended into one number. Risk is concentrated, as it usually is: 24 of 9,481 files are git hotspots, and they average 4.9 — which is where the fixes pay off most.
Do next
4 things worth doing this quarter.
Worth planning
Break up __init__ (CCN 40, 159 lines)
platform/broadcom/sonic-platform-modules-micas/common/lib/plat_hal/chassisbase.py:49
__init__ nests its control flow deeply, and part of it is duplicated, so splitting it also removes a copy; 3 files import it, changed 1 time in 90 days.
- gain
- up to +1.0 health on this file(inferred)
- finding
- Nested complexity
- size
- CCN 40, 159 lines, nests 6 deep
- severity
- high
Medium effort, worth a checkBreak up schema_validation (CCN 18, 52 lines)
platform/pddf/i2c/utils/pddfparse.py:1677
schema_validation nests its control flow deeply; 15 files import it, changed 2 times in 90 days.
- gain
- up to +0.2 health on this file(inferred)
- finding
- Nested complexity
- size
- CCN 18, 52 lines, nests 8 deep
- severity
- critical
Medium effort, worth a checkDelete 10,432 unused symbols and files (344,996 lines)
Nothing in the graph reaches them, across 2,836 files; every reader and agent pays to skip them.
- symbols
- 10432
- lines
- 344,996
- safe to delete
- Yes(inferred)
Medium effortFlatten the nesting in getETValue
device/micas/x86_64-micas_m2-w6920-32qc2x-r0/monitor.py:329
getETValue nests its control flow deeply, and part of it is duplicated, so splitting it also removes a copy.
- gain
- up to +1.3 health on this file(inferred)
- finding
- Nested complexity
- size
- CCN 27, 74 lines, nests 5 deep
- severity
- high
Medium effort, worth a check
Improve what Repowise can see
Add a test coverage report
Without one, Repowise cannot tell tested code from untested code, so every test-related action says “unknown”.
- line coverage
- Unknown, no report
Small effort
- Lines of code
- 2.8M
Recent activity
All commitsCommits
No commits indexed yet.
Decisions
- Add new implementations only to kcompat_impl.hproposed · 2mo ago
- Use only NEED_/HAVE_ checks; avoid kernel version checksproposed · 2mo ago
- Offset DEVLINK_PARAM_GENERIC_ID_MAX for backport safetyproposed · 2mo ago
- Make dhcpservd readiness check idempotentproposed · 2mo ago
- Fix kea-dhcp4 paths for Kea 2.6 strict validation (Trixie upgrade)proposed · 2mo ago
- Omit DHCP server gateway when gateway is optionalproposed · 2mo ago
Everything we found
33,482 open
Every detector's open count by area, each with its worst example. An inventory, not a to-do list: the actions above are the part worth doing.
- worst item is critical severity. Code health12,602Nested complexity · src/sonic-yang-mgmt/sonic_yang_ext.py45 findings · 8.0 deducted
- worst item is medium severity. Refactoring1,966onie_tlv+1.7 health, XL effort · platform/broadcom/sonic-platform-modules-tencent/common/lib/eepromutil/onietlv.py
- worst item is medium severity. Decisions73src/system-health/tests/test_system_health.py49 awaiting review · 24 hotspots ungoverned
- worst item is medium severity. Ownership6,023build_debian.sh85% single-owner concentration, 9 commits in 90d
- worst item is low severity. Dead code12,818device/accton/x86_64-accton_as4630_54te-r0/sonic_platform/chassis.pyUnreachable symbol (390 lines)
Composition
Open the graphExplore this codebase
- Docs16,705 pages across 8 modules
- ChatAsk this codebase a question and get an answer with its sources.
- Files9,481 files with per-file docs, health and history
- ArchitectureDependency graph, layers, and 67 entry points
- Code healthPer-file scores, 13,127 open findings, coverage and refactoring targets
- Knowledge graphEntities, communities, and the paths between them
- Change couplingFiles that keep changing together, mined from commit history
- CommitsChange-risk ranked history with agent provenance
- ContributorsBus factor, per-file maintainers, and the human/agent split
- StatsSize class, origin, lifetime churn, rhythm and records
- CostsWhat indexing this snapshot cost, by model and by run.