feat(m1): three-run determinism gate + ghost surgery-target rejection (R1.1/R1.4)

Analysed against 9e761b2c10 files changedby 2233admin
Open PR on GitHub

Change-risk score

9.5out of 10Elevated
Repository health
5.1to5.5base against this head

This change sits in the top third of this repository's own risk distribution, the band worth reviewing closely. It is riskier than 89% of this repository's own commits.

No changed file lost health in this diff. Nothing outside this PR depends on a contract it changed.

Files changed
10
in this diff
Contracts changed
0
removed or signature
Outside callers
0
not in this diff
Findings added
42
5 resolved

Blast radius on the repo map

Every file in the repository, grouped into its own directories and sized by lines. The ones this PR changes are lit, and everything that imports them is marked.

cratesdocsorchestrationprototy…skills/code-in…code-intel-cliplansevidenceschemassrctestsaudit_reportclimcp_serve
changed, health fellchanged, health rosechanged, health heldimports a changed fileuntouchedchanged by this PR

Drawing 574 of 748 files at a readable size, grouped by directory and sized by lines of code. 10 changed here reach 5 more by import. 174 are too small to see at this width, which is what the frame below is for.

Inside crates/code-intel-cli/src

audit_reportauthorit…change_a…change_r…cligit_remo…graphmcp_servecommand_cata…routesartifact_r…artifacts.…assist…author…author…bounda…bounda…builti…capabi…cap…cha…cod…commit…compat…compat…conten…dag_co…dag_run.…decision…decision…decision…declared…delivery…doc…doc…edi…edi…evi…evi…execut…file_b…graph_…hospit…hospit…impact…intern…metho…metho…model…nativ…orc…pon…pro…project_o…providers…repin.rsrepowise_…repowise_…repowise_…rout…run_…run_…runt…sent…sentrux_analy…sentrux_gate.…session_evide…snapshot.rsspan_app…stable_a…staged_a…structur…survival…tool_eff…un…mod…tes…cli.rscli_t…enums…reg…reg…ren…re…re…vali…valid…exe…mo…gi…mo…legacy.…conf…mod.rspa…pr…inp…re…re…mod.rsmod…test…handl…ident…mod.rste…to…sc…te…pr…sc…mod…tes…mod.rs

158 files, 6 changed by this PR and 5 that import one. Click any directory above to frame it instead.

Changed

What this PR added, and what it took away

Introduced findings are the ones inside the lines this PR added, not the file's existing ones. The resolved column is the only place in the product that lists them.

Introduced (42)
  • highnested complexity
    crates/code-intel-cli/src/determinism_check.rs:459

    json_diff nests 6 levels deep

  • highnested complexity
    crates/code-intel-cli/src/determinism_check.rs:382

    first_divergence nests 6 levels deep

  • highcomplex method
    crates/code-intel-cli/src/determinism_check.rs:106

    parse has cyclomatic complexity 23

  • mediumnested complexity
    crates/code-intel-cli/src/determinism_check.rs:106

    parse nests 4 levels deep

  • mediumnested complexity
    crates/code-intel-cli/src/hospital_diagnosis.rs:65

    execute nests 4 levels deep

  • mediumdry violation
    crates/code-intel-cli/src/cli/command_catalog/routes/determinism_routes.rs:11

    34% of file duplicated; worst clone shares 10 lines with crates/code-intel-cli/src/cli/command_catalog/routes/provider_routes.rs

  • mediumdry violation
    crates/code-intel-cli/src/cli/command_catalog/routes/provider_routes.rs:81

    50% of file duplicated; worst clone shares 13 lines with crates/code-intel-cli/src/cli/command_catalog/routes/provider_routes.rs

  • mediumdry violation
    crates/code-intel-cli/src/determinism_check_tests.rs:106

    33% of file duplicated; worst clone shares 15 lines with crates/code-intel-cli/src/determinism_check_tests.rs

  • mediumlarge method
    crates/code-intel-cli/src/determinism_check.rs:106

    parse is 109 lines long

  • mediumcomplex method
    crates/code-intel-cli/src/determinism_check.rs:459

    json_diff has cyclomatic complexity 14

  • mediumcomplex method
    crates/code-intel-cli/src/determinism_check.rs:382

    first_divergence has cyclomatic complexity 11

  • mediumduplicated assertion block
    crates/code-intel-cli/tests/hospital_diagnosis.rs:721

    assertion block at lines 721-729 is duplicated in crates/code-intel-cli/tests/hospital_diagnosis.rs

  • mediumduplicated assertion block
    crates/code-intel-cli/tests/hospital_diagnosis.rs:790

    assertion block at lines 790-797 is duplicated in crates/code-intel-cli/tests/hospital_diagnosis.rs

  • mediumio in loop
    crates/code-intel-cli/src/determinism_check.rs:261

    a filesystem call runs once per loop iteration (N+1 / IO-in-loop)

  • mediumio in loop
    crates/code-intel-cli/src/determinism_check.rs:345

    a filesystem call runs once per loop iteration (N+1 / IO-in-loop)

  • mediumio in loop
    crates/code-intel-cli/tests/determinism_check.rs:37

    a filesystem call runs once per loop iteration (N+1 / IO-in-loop)

  • mediumio in loop
    crates/code-intel-cli/tests/determinism_check.rs:54

    a filesystem call runs once per loop iteration (N+1 / IO-in-loop)

  • mediumio in loop
    crates/code-intel-cli/tests/determinism_check.rs:55

    a filesystem call runs once per loop iteration (N+1 / IO-in-loop)

  • lowdry violation
    crates/code-intel-cli/tests/determinism_check.rs:109

    14% of file duplicated; worst clone shares 9 lines with crates/code-intel-cli/tests/determinism_check.rs

  • lowerror handling
    crates/code-intel-cli/src/determinism_check.rs:183

    panic!/unreachable!/todo!/unimplemented! aborts the process unconditionally

  • lowerror handling
    crates/code-intel-cli/src/determinism_check.rs:338

    unwrap/expect turns a recoverable error into a crash

  • lowerror handling
    crates/code-intel-cli/src/determinism_check.rs:436

    panic!/unreachable!/todo!/unimplemented! aborts the process unconditionally

  • lowerror handling
    crates/code-intel-cli/src/determinism_check.rs:482

    panic!/unreachable!/todo!/unimplemented! aborts the process unconditionally

  • lowlarge method
    crates/code-intel-cli/src/determinism_check.rs:382

    first_divergence is 61 lines long

  • lowlarge method
    crates/code-intel-cli/src/determinism_check.rs:245

    check is 63 lines long

  • lowprimitive obsession
    crates/code-intel-cli/tests/hospital_diagnosis.rs:249

    run_with_options takes 5 parameters

  • lowbumpy road
    crates/code-intel-cli/src/hospital_diagnosis.rs:65

    execute has 3 nested blocks at the same level (bumpy road)

  • lowerror handling
    crates/code-intel-cli/tests/determinism_check.rs:16

    unwrap/expect turns a recoverable error into a crash

  • lowerror handling
    crates/code-intel-cli/tests/determinism_check.rs:33

    unwrap/expect turns a recoverable error into a crash

  • lowerror handling
    crates/code-intel-cli/tests/determinism_check.rs:37

    unwrap/expect turns a recoverable error into a crash

  • lowerror handling
    crates/code-intel-cli/tests/determinism_check.rs:43

    unwrap/expect turns a recoverable error into a crash

  • lowerror handling
    crates/code-intel-cli/tests/determinism_check.rs:54

    unwrap/expect turns a recoverable error into a crash

  • lowerror handling
    crates/code-intel-cli/tests/determinism_check.rs:55

    unwrap/expect turns a recoverable error into a crash

  • lowerror handling
    crates/code-intel-cli/tests/determinism_check.rs:58

    unwrap/expect turns a recoverable error into a crash

  • lowerror handling
    crates/code-intel-cli/tests/determinism_check.rs:63

    unwrap/expect turns a recoverable error into a crash

  • lowerror handling
    crates/code-intel-cli/tests/hospital_diagnosis.rs:268

    unwrap/expect turns a recoverable error into a crash

  • lowerror handling
    crates/code-intel-cli/tests/hospital_diagnosis.rs:268

    unwrap/expect turns a recoverable error into a crash

  • lowerror handling
    crates/code-intel-cli/tests/hospital_diagnosis.rs:270

    unwrap/expect turns a recoverable error into a crash

  • lowerror handling
    crates/code-intel-cli/tests/hospital_diagnosis.rs:281

    unwrap/expect turns a recoverable error into a crash

  • lowhot path sync io
    crates/code-intel-cli/tests/hospital_diagnosis.rs:268

    a blocking filesystem call runs on a hot, request-reachable path; its latency is paid on every call through this function

  • lowhot path sync io
    crates/code-intel-cli/tests/hospital_diagnosis.rs:685

    a blocking filesystem call runs on a hot, request-reachable path; its latency is paid on every call through this function

  • lowhot path sync io
    crates/code-intel-cli/tests/hospital_diagnosis.rs:789

    a blocking filesystem call runs on a hot, request-reachable path; its latency is paid on every call through this function

Resolved (5)
  • function hotspot
    crates/code-intel-cli/src/cli/command_catalog/mod.rs
  • duplicated assertion block
    crates/code-intel-cli/src/cli/command_catalog/tests.rs
  • brain method
    crates/code-intel-cli/src/cli/command_catalog/tests.rs
  • io in loop
    crates/code-intel-cli/src/cli/command_catalog/tests.rs
  • function hotspot
    crates/code-intel-cli/src/hospital_diagnosis.rs

Who else knows this code

The primary author of each changed file by share of its recent commits, mined from git history. Advisory: it says who has context, not who must review.

  • crates/code-intel-cli/src/main.rs2233admin 55% of 39 commits · the PR author
  • crates/code-intel-cli/src/execution_policy.rsCurry 54% of 5 commits
  • crates/code-intel-cli/src/cli/command_catalog/mod.rs2233admin 100% of 9 commits · the PR author
  • crates/code-intel-cli/src/cli/legacy.rs2233admin 100% of 7 commits · the PR author
  • crates/code-intel-cli/tests/hospital_diagnosis.rsCurry 91% of 5 commits

Get this on your own pull requests

This page came from an index of 2233admin/code-intel-pipeline. No model calls, no configuration, and it refreshes on every push. Install the bot and every pull request gets one of these.

feat(m1): three-run determinism gate + ghost surgery-target rejection (R1.1/R1.4) · 2233admin/code-intel-pipeline #204 · Repowise