正式版前调研+优化: mattpocock/skills 出处钉死 + 契约/schema 对账闸 + 六条复查落账

Analysed against 188058c12 files changedby 2233admin
Open PR on GitHub

Change-risk score

9.0out of 10Elevated
Repository health
3.5to3.5base against this head

This change sits in the top third of this repository's own risk distribution, the band worth reviewing closely. It is riskier than 71% of this repository's own commits.

The largest health movement is in internalization_record.rs, down 0.2. Nothing outside this PR depends on a contract it changed.

Files changed
2
in this diff
Contracts changed
0
removed or signature
Outside callers
0
not in this diff
Findings added
14
2 resolved

The repository map needs the file index from this snapshot, which is not available yet. Everything below is unaffected.

What this PR added, and what it took away

Introduced findings are the ones inside the lines this PR added, not the file's existing ones. The resolved column is the only place in the product that lists them.

Introduced (14)
  • mediumduplicated assertion block
    crates/code-intel-cli/tests/internalization_record.rs:577

    assertion block at lines 577-579 is duplicated in crates/code-intel-cli/tests/internalization_record.rs

  • mediumduplicated assertion block
    crates/code-intel-cli/tests/internalization_record.rs:587

    assertion block at lines 587-589 is duplicated in crates/code-intel-cli/tests/internalization_record.rs

  • mediumduplicated assertion block
    crates/code-intel-cli/tests/internalization_record.rs:596

    assertion block at lines 596-598 is duplicated in crates/code-intel-cli/tests/internalization_record.rs

  • mediumduplicated assertion block
    crates/code-intel-cli/tests/internalization_record.rs:606

    assertion block at lines 606-609 is duplicated in crates/code-intel-cli/tests/internalization_record.rs

  • lowprimitive obsession
    crates/code-intel-cli/tests/internalization_record.rs:567

    assert_verified_research_candidate takes 5 parameters

  • lowlarge method
    crates/code-intel-cli/src/artifact_ref.rs:3391

    every_registered_contract_publishes_a_schema_file is 65 lines long

  • lowerror handling
    crates/code-intel-cli/tests/internalization_record.rs:576

    unwrap/expect turns a recoverable error into a crash

  • lowerror handling
    crates/code-intel-cli/tests/internalization_record.rs:595

    unwrap/expect turns a recoverable error into a crash

  • lowerror handling
    crates/code-intel-cli/tests/internalization_record.rs:599

    unwrap/expect turns a recoverable error into a crash

  • lowerror handling
    crates/code-intel-cli/tests/internalization_record.rs:603

    unwrap/expect turns a recoverable error into a crash

  • lowerror handling
    crates/code-intel-cli/tests/internalization_record.rs:611

    unwrap/expect turns a recoverable error into a crash

  • lowerror handling
    crates/code-intel-cli/tests/internalization_record.rs:612

    unwrap/expect turns a recoverable error into a crash

  • lowhot path sync io
    crates/code-intel-cli/src/artifact_ref.rs:3187

    a blocking filesystem call runs on a hot, request-reachable path; its latency is paid on every call through this function

  • lowhot path sync io
    crates/code-intel-cli/src/artifact_ref.rs:3356

    a blocking filesystem call runs on a hot, request-reachable path; its latency is paid on every call through this function

Resolved (2)
  • io in loop
    crates/code-intel-cli/tests/internalization_record.rs
  • dry violation
    crates/code-intel-cli/src/artifact_ref.rs

Who else knows this code

The primary author of each changed file by share of its recent commits, mined from git history. Advisory: it says who has context, not who must review.

  • crates/code-intel-cli/src/artifact_ref.rs2233admin 80% of 10 commits · the PR author
  • crates/code-intel-cli/tests/internalization_record.rsCurry 70% of 10 commits · the PR author

Get this on your own pull requests

This page came from an index of 2233admin/code-intel-pipeline. No model calls, no configuration, and it refreshes on every push. Install the bot and every pull request gets one of these.

正式版前调研+优化: mattpocock/skills 出处钉死 + 契约/schema 对账闸 + 六条复查落账 · 2233admin/code-intel-pipeline #212 · Repowise