fix(capability): reject bin forwarder manifests, fall back to CODE_INTEL_HOME (#218)

Analysed against cea9338310 files changedby 2233admin
Open PR on GitHub

Change-risk score

8.7out of 10Typical
Repository health
3.6to3.7base against this head

This change sits in the middle third of this repository's own risk distribution, so it is about as risky as the work around it. It is riskier than 63% of this repository's own commits.

The largest health movement is in walk.rs, down 0.8. Nothing outside this PR depends on a contract it changed.

Files changed
10
in this diff
Contracts changed
0
removed or signature
Outside callers
0
not in this diff
Findings added
3
13 resolved

Blast radius on the repo map

Every file in the repository, grouped into its own directories and sized by lines. The ones this PR changes are lit, and everything that imports them is marked.

cratesdocsorchestrationcode-intel-cliadrarchiveauditinternaliza…retirementsschemassrctestsplanse02-recommendere03-provider-prefl…e04-codenexus-dire…e05-publi…e07-nativ…e08-hospi…e09-doctor-wrap…e10-indexaudit_re…change_a…clievidenceevidenceevidenceevidenceevidenceevidenceevidenceevidence
changed, health fellchanged, health rosechanged, health heldimports a changed fileuntouchedchanged by this PR

Drawing 736 of 738 files at a readable size, grouped by directory and sized by lines of code. 10 changed here reach 8 more by import. 2 are too small to see at this width, which is what the frame below is for.

Inside crates/code-intel-cli

srctestsaudit_reportchange_agen…change_riskclidoctor_bootstrapfile_gategit_remote_…mcp_servecommand_catalogroutesadapt…admis…artif…artif…artif…artif…assis…assis…autho…autho…bound…bound…built…capab…capab…chang…cli.rscoden…commi…commi…compa…compa…conte…dag_c…dag_r…decis…decis…decis…decla…deliv…docto…docto…edit_…edit_…env_c…evide…evide…execu…file_…graph…harde…hospi…hospi…i18n.…impac…inter…invoc…main.…metho…metho…model…nativ…orche…phase…ponyt…proje…proje…provi…repin…repow…repow…repow…repow…route…run_c…run_c…run_e…runti…sentr…sentr…sentr…sentr…sessi…snaps…span_…stabl…stage…struc…survi…tool_…ar…ar…as…as…as…au…au…ca…cl…co…compa…compa…dag_c…dag_r…decis…decis…decis…decla…deliv…do…do…en…ev…ev…fi…gr…ho…insta…inter…mcp_s…metho…metho…mindw…nativ…po…po…pr…pr…pr…re…repo…repo…repo…run_…run_…ru…sc…se…se…se…sentru…sessio…snapsh…span_a…st…su…to…under…versi…mod.rstests…cl…cl…en…js…mo…mo…mo…re…re…rend…rend…rend…re…va…valida…valida…com…exe…clust…cocha…mod.rsre…te…git.rsmod.rsrende…sco…sig…hel…leg…pri…conf…iden…mod.…path…mod.rsrepor…rules…tests…ho…in…mo…regist…resolv…te…mo…te…mo…te…handl…mod.rstests…tools…scori…con…mod…tes…run_…serv…

217 files, 9 changed by this PR and 8 that import one. This PR changes 10 files in total, spread across more than one top-level directory. Click any directory above to frame it instead.

Changed

What this PR added, and what it took away

Introduced findings are the ones inside the lines this PR added, not the file's existing ones. The resolved column is the only place in the product that lists them.

Introduced (3)
  • mediumcomplex method
    crates/code-intel-cli/src/file_gate/walk.rs:21

    walk_candidates has cyclomatic complexity 10

  • lowhot path sync io
    crates/code-intel-cli/src/capability.rs:1196

    a blocking filesystem call runs on a hot, request-reachable path; its latency is paid on every call through this function

  • lowhot path sync io
    crates/code-intel-cli/src/orchestration.rs:1224

    a blocking filesystem call runs on a hot, request-reachable path; its latency is paid on every call through this function

Resolved (13)
  • function hotspot
    crates/code-intel-cli/src/capability.rs
  • function hotspot
    crates/code-intel-cli/src/capability_inventory.rs
  • io in loop
    crates/code-intel-cli/src/capability_inventory.rs
  • dry violation
    crates/code-intel-cli/src/doctor_adapter.rs
  • io in loop
    crates/code-intel-cli/tests/artifact_ref.rs
  • io in loop
    crates/code-intel-cli/tests/capability_exec.rs
  • duplicated assertion block
    crates/code-intel-cli/tests/internalization_record.rs
  • io in loop
    crates/code-intel-cli/tests/internalization_record.rs
  • function hotspot
    crates/code-intel-cli/tests/native_code_evidence.rs
  • io in loop
    crates/code-intel-cli/tests/native_code_evidence.rs
  • hot path sync io
    crates/code-intel-cli/tests/snapshot_identity.rs
  • function hotspot
    skills/code-intel-pipeline/scripts/bootstrap.py
  • hot path sync io
    skills/code-intel-pipeline/scripts/bootstrap.py

Who else knows this code

The primary author of each changed file by share of its recent commits, mined from git history. Advisory: it says who has context, not who must review.

  • crates/code-intel-cli/tests/capability_exec.rsCurry 83% of 14 commits · the PR author
  • crates/code-intel-cli/tests/snapshot_identity.rsCurry 99% of 3 commits · the PR author
  • crates/code-intel-cli/src/orchestration.rsCurry 58% of 6 commits · the PR author
  • crates/code-intel-cli/tests/internalization_record.rsCurry 67% of 11 commits · the PR author
  • crates/code-intel-cli/src/capability.rsCurry 92% of 8 commits · the PR author

Get this on your own pull requests

This page came from an index of 2233admin/code-intel-pipeline. No model calls, no configuration, and it refreshes on every push. Install the bot and every pull request gets one of these.