feat(workflow): modernize spec workflow adapters

Analysed against 3bff3b2d10 files changedby 2233admin
Open PR on GitHub

Change-risk score

9.8out of 10Elevated
Repository health
3.2to3.7base against this head

This change sits in the top third of this repository's own risk distribution, the band worth reviewing closely. It is riskier than 99% of this repository's own commits.

The largest health movement is in content_contract.rs, down 0.2. Nothing outside this PR depends on a contract it changed.

Files changed
10
in this diff
Contracts changed
0
removed or signature
Outside callers
0
not in this diff
Findings added
51
7 resolved

Blast radius on the repo map

Every file in the repository, grouped into its own directories and sized by lines. The ones this PR changes are lit, and everything that imports them is marked.

cratesdocsorchestrationprototy…skills/code-in…code-intel-cliplansevidenceschemassrctestsaudit_reportclimcp_serve
changed, health fellchanged, health rosechanged, health heldimports a changed fileuntouchedchanged by this PR

Drawing 574 of 748 files at a readable size, grouped by directory and sized by lines of code. 10 changed here reach 11 more by import. 174 are too small to see at this width, which is what the frame below is for.

Inside crates/code-intel-cli

srctestsaudit_reportchange_riskclimcp_servecommand…admissi…artifac…artifac…art…art…ass…aut…aut…bou…bou…bui…cap…cap…cha…compat…conten…dag_co…dag_ru…decisi…decisi…decisi…de…de…do…ed…ed…ev…evid…exec…file…grap…hosp…hosp…impa…inte…met…met…mod…nat…orc…pon…pro…pro…provi…repin…repow…repow…repow…run_c…run_…runt…sent…sent…sentrux_g…sessi…snapshot.rsst…staged…stru…surv…tool…unde…artif…art…au…capability_exec.rscli_h…coden…compa…dag_c…dag_r…decision…decision…delivery_lig…do…do…en…ev…ev…fi…gr…hospit…in…internalization_re…mc…me…me…na…ponyt…prima…proje…proje…repin…ru…run_…runt…sche…sent…sent…snaps…span…stag…su…un…cl…reg…ren…va…vali…comp…execut…mo…tes…git…mod…si…lega…co…mod.…path…prob…ru…re…test…mod.rste…hand…mod.…sc…te…sc…mod.…tests.rsmod.rs

220 files, 7 changed by this PR and 11 that import one. Click any directory above to frame it instead.

Changed

What this PR added, and what it took away

Introduced findings are the ones inside the lines this PR added, not the file's existing ones. The resolved column is the only place in the product that lists them.

Introduced (51)
  • criticalcomplex conditional
    crates/code-intel-cli/src/workflow_recommendation_contract.rs:103

    if condition combines 7 boolean operators

  • criticallarge method
    crates/code-intel-cli/src/workflow_recommendation.rs:339

    evaluate is 203 lines long

  • criticalcomplex method
    crates/code-intel-cli/src/workflow_recommendation.rs:339

    evaluate has cyclomatic complexity 32

  • mediumcomplex conditional
    crates/code-intel-cli/src/workflow_recommendation_contract.rs:476

    if condition combines 4 boolean operators

  • mediumcomplex conditional
    crates/code-intel-cli/src/workflow_recommendation_contract.rs:444

    if condition combines 4 boolean operators

  • mediumcomplex conditional
    crates/code-intel-cli/src/workflow_recommendation_contract.rs:41

    if condition combines 4 boolean operators

  • mediumcomplex method
    crates/code-intel-cli/src/workflow_recommendation_contract.rs:327

    validate_rendered_candidate has cyclomatic complexity 9

  • mediumcomplex method
    crates/code-intel-cli/src/workflow_recommendation_contract.rs:208

    validate_provenance has cyclomatic complexity 10

  • mediumcomplex method
    crates/code-intel-cli/src/workflow_recommendation_contract.rs:129

    validate_v2 has cyclomatic complexity 9

  • mediumcomplex method
    crates/code-intel-cli/src/workflow_recommendation_contract.rs:74

    validate_authority_event_bytes has cyclomatic complexity 11

  • mediumcomplex method
    crates/code-intel-cli/src/workflow_recommendation_contract.rs:5

    validate_catalog has cyclomatic complexity 11

  • mediumcomplex method
    crates/code-intel-cli/src/workflow_recommendation.rs:633

    detect_presence has cyclomatic complexity 14

  • mediumprimitive obsession
    crates/code-intel-cli/src/workflow_recommendation.rs:550

    render_candidate takes 7 parameters

  • lowcomplex conditional
    crates/code-intel-cli/src/workflow_recommendation_contract.rs:560

    if condition combines 3 boolean operators

  • lowcomplex conditional
    crates/code-intel-cli/src/workflow_recommendation_contract.rs:348

    if condition combines 3 boolean operators

  • lowerror handling
    crates/code-intel-cli/src/content_contract.rs:313

    unwrap/expect turns a recoverable error into a crash

  • lowbumpy road
    crates/code-intel-cli/src/workflow_recommendation.rs:339

    evaluate has 3 nested blocks at the same level (bumpy road)

  • lowdry violation
    crates/code-intel-cli/src/workflow_recommendation_contract.rs:124

    10% of file duplicated; worst clone shares 17 lines with crates/code-intel-cli/src/workflow_recommendation_contract.rs

  • lowerror handling
    crates/code-intel-cli/src/workflow_recommendation_contract_tests.rs:5

    unwrap/expect turns a recoverable error into a crash

  • lowerror handling
    crates/code-intel-cli/src/workflow_recommendation_contract_tests.rs:12

    unwrap/expect turns a recoverable error into a crash

  • lowerror handling
    crates/code-intel-cli/src/workflow_recommendation_contract_tests.rs:12

    unwrap/expect turns a recoverable error into a crash

  • lowlarge method
    crates/code-intel-cli/src/workflow_recommendation_contract.rs:461

    validate_action is 67 lines long

  • lowlarge method
    crates/code-intel-cli/src/workflow_recommendation_contract.rs:327

    validate_rendered_candidate is 67 lines long

  • lowlarge method
    crates/code-intel-cli/src/workflow_recommendation_contract.rs:129

    validate_v2 is 77 lines long

  • lowlarge method
    crates/code-intel-cli/src/workflow_recommendation_contract.rs:5

    validate_catalog is 63 lines long

  • lowerror handling
    crates/code-intel-cli/src/workflow_recommendation.rs:336

    unwrap/expect turns a recoverable error into a crash

  • lowerror handling
    crates/code-intel-cli/src/workflow_recommendation.rs:347

    unwrap/expect turns a recoverable error into a crash

  • lowerror handling
    crates/code-intel-cli/src/workflow_recommendation.rs:456

    unwrap/expect turns a recoverable error into a crash

  • lowerror handling
    crates/code-intel-cli/src/workflow_recommendation.rs:559

    unwrap/expect turns a recoverable error into a crash

  • lowerror handling
    crates/code-intel-cli/src/workflow_recommendation.rs:560

    unwrap/expect turns a recoverable error into a crash

  • lowerror handling
    crates/code-intel-cli/src/workflow_recommendation.rs:572

    unwrap/expect turns a recoverable error into a crash

  • lowerror handling
    crates/code-intel-cli/src/workflow_recommendation.rs:578

    unwrap/expect turns a recoverable error into a crash

  • lowerror handling
    crates/code-intel-cli/tests/capability_exec.rs:1751

    unwrap/expect turns a recoverable error into a crash

  • lowerror handling
    crates/code-intel-cli/tests/capability_exec.rs:1751

    unwrap/expect turns a recoverable error into a crash

  • lowerror handling
    crates/code-intel-cli/tests/capability_exec.rs:1752

    unwrap/expect turns a recoverable error into a crash

  • lowerror handling
    crates/code-intel-cli/tests/capability_exec.rs:1777

    unwrap/expect turns a recoverable error into a crash

  • lowerror handling
    crates/code-intel-cli/tests/capability_exec.rs:1781

    unwrap/expect turns a recoverable error into a crash

  • lowerror handling
    crates/code-intel-cli/tests/capability_exec.rs:1781

    unwrap/expect turns a recoverable error into a crash

  • lowerror handling
    crates/code-intel-cli/tests/capability_exec.rs:1786

    unwrap/expect turns a recoverable error into a crash

  • lowerror handling
    crates/code-intel-cli/tests/capability_exec.rs:1807

    unwrap/expect turns a recoverable error into a crash

  • lowhot path sync io
    crates/code-intel-cli/tests/capability_exec.rs:1658

    a blocking filesystem call runs on a hot, request-reachable path; its latency is paid on every call through this function

  • lowhot path sync io
    crates/code-intel-cli/tests/capability_exec.rs:1781

    a blocking filesystem call runs on a hot, request-reachable path; its latency is paid on every call through this function

  • lowhot path sync io
    crates/code-intel-cli/tests/capability_exec.rs:1893

    a blocking filesystem call runs on a hot, request-reachable path; its latency is paid on every call through this function

  • lowhot path sync io
    crates/code-intel-cli/tests/capability_exec.rs:1920

    a blocking filesystem call runs on a hot, request-reachable path; its latency is paid on every call through this function

  • lowhot path sync io
    crates/code-intel-cli/tests/capability_exec.rs:1961

    a blocking filesystem call runs on a hot, request-reachable path; its latency is paid on every call through this function

  • lowhot path sync io
    crates/code-intel-cli/tests/capability_exec.rs:1991

    a blocking filesystem call runs on a hot, request-reachable path; its latency is paid on every call through this function

  • lowhot path sync io
    crates/code-intel-cli/tests/capability_exec.rs:2041

    a blocking filesystem call runs on a hot, request-reachable path; its latency is paid on every call through this function

  • lowhot path sync io
    crates/code-intel-cli/tests/capability_exec.rs:2067

    a blocking filesystem call runs on a hot, request-reachable path; its latency is paid on every call through this function

  • lowhot path sync io
    crates/code-intel-cli/tests/capability_exec.rs:2122

    a blocking filesystem call runs on a hot, request-reachable path; its latency is paid on every call through this function

  • lowhot path sync io
    crates/code-intel-cli/tests/capability_exec.rs:2196

    a blocking filesystem call runs on a hot, request-reachable path; its latency is paid on every call through this function

  • lowhot path sync io
    crates/code-intel-cli/tests/run_commit.rs:170

    a blocking filesystem call runs on a hot, request-reachable path; its latency is paid on every call through this function

Resolved (7)
  • dry violation
    crates/code-intel-cli/src/content_contract.rs
  • dry violation
    crates/code-intel-cli/src/artifact_ref.rs
  • function hotspot
    crates/code-intel-cli/src/capability.rs
  • io in loop
    crates/code-intel-cli/tests/artifact_ref.rs
  • churn risk
    crates/code-intel-cli/tests/capability_exec.rs
  • duplicated assertion block
    crates/code-intel-cli/tests/internalization_record.rs
  • io in loop
    crates/code-intel-cli/tests/internalization_record.rs

Who else knows this code

The primary author of each changed file by share of its recent commits, mined from git history. Advisory: it says who has context, not who must review.

  • crates/code-intel-cli/tests/capability_exec.rsCurry 76% of 16 commits
  • crates/code-intel-cli/src/artifact_ref.rs2233admin 82% of 11 commits · the PR author
  • crates/code-intel-cli/tests/internalization_record.rsCurry 67% of 12 commits
  • crates/code-intel-cli/src/capability.rsCurry 81% of 9 commits
  • crates/code-intel-cli/tests/schema_lifecycle.rsCurry 100% of 1 commits

Get this on your own pull requests

This page came from an index of 2233admin/code-intel-pipeline. No model calls, no configuration, and it refreshes on every push. Install the bot and every pull request gets one of these.