Loading pull request analysis

2233admin/opencli-Razormind·#110· merged

fix: recover CI and runtime contracts

Analysed against ecc332ec10 files changedby 2233admin

Change-risk score

9.4out of 10Elevated

Repository health

4.5to4.8base against this head

This change sits in the top third of this repository's own risk distribution, the band worth reviewing closely. It is riskier than 82% of this repository's own commits.

The largest health movement is in page.tsx, down 3.7. 4 contracts changed, called by 26 symbols in files this PR does not touch.

Files changed: 10; in this diff
Contracts changed: 4; removed or signature
Outside callers: 26; not in this diff
Findings added: 35; 1 resolved

Contracts this PR changes

Only symbols that were removed or had their signature changed. An added symbol has no prior callers, and a body-only change leaves the caller's contract intact, so neither is a finding.

submit_tasksignature changedbackend/services/browser_space_service.py:416

12 callers outside this PR.

backend/api/v1/browser_spaces.py::submit_browser_space_tasktests/unit/test_browser_space_service.py::test_cancellation_acknowledges_and_releases_oncetests/unit/test_browser_space_service.py::test_close_waits_for_cross_process_cancellation_acknowledgementtests/unit/test_browser_space_service.py::test_closed_space_rejects_new_tasktests/unit/test_browser_space_service.py::test_cross_process_cancellation_waits_for_runtime_cleanuptests/unit/test_browser_space_service.py::test_deferred_submission_commits_without_runtime_call

What this PR added, and what it took away

Introduced findings are the ones inside the lines this PR added, not the file's existing ones. The resolved column is the only place in the product that lists them.

Introduced (35)

criticalnested complexity
frontend/app/(app)/control/odp-state/page.tsx:72
OdpStatePage nests 7 levels deep
criticallarge method
frontend/components/shell/global-agent-dock.tsx:70
GlobalAgentDock is 263 lines long
criticalcomplex method
backend/workflow/delivery_execution.py:392
execute_delivery has cyclomatic complexity 38
highprimitive obsession
backend/api/v1/studio_workflows.py:847
list_project_workflow_evidence_batches takes 9 parameters

Who else knows this code

The primary author of each changed file by share of its recent commits, mined from git history. Advisory: it says who has context, not who must review.

tests/unit/test_agent_server.pyCurry 54% of 8 commits
frontend/lib/navigation.tslunnt 39% of 21 commits
backend/models/browser.py1012839419a-alt 75% of 3 commits
backend/workflow/capability_projection.py2233admin 47% of 34 commits · the PR author
frontend/components/auth/auth-provider.tsx1012839419a-alt 78% of 8 commits

Tests that cover this change

Test files that import a file this PR changes. Not a coverage measurement: it is the import graph, so it says which tests are worth running, not which lines they reach.

tests/integration/test_chat_api.py
tests/skills/test_loop.py
tests/unit/llm/test_pr_e_consumers.py
tests/integration/test_opencli_channel_api.py
tests/integration/test_weibo_zhihu_collection.py
tests/unit/test_acquisition_capabilities.py
tests/integration/test_workflow_fleet_api.py
tests/integration/test_workflow_opencli_hda_trace_api.py
tests/unit/test_acquisition_runner.py

Get this on your own pull requests

This page came from an index of 2233admin/opencli-Razormind. No model calls, no configuration, and it refreshes on every push. Install the bot and every pull request gets one of these.

Install the PR Bot Index a repository

tests/unit/test_browser_space_service.py::test_distinct_spaces_can_execute_concurrently

tests/unit/test_browser_space_service.py::test_idempotency_calls_executor_once

tests/unit/test_browser_space_service.py::test_latest_task_is_scoped_to_requested_space

tests/unit/test_browser_space_service.py::test_result_and_events_are_bounded_and_ordered

tests/unit/test_browser_space_service.py::test_runtime_timeout_finishes_task_as_failed

tests/unit/test_browser_space_service.py::test_same_space_tasks_are_serialized

execute_deliverysignature changedbackend/workflow/delivery_execution.py:392

10 callers outside this PR, 9 inside it.

backend/api/v1/delivery_execution_routes.py::executetests/integration/test_delivery_execution_api.py::test_execution_and_read_survive_recreated_database_sessionstests/integration/test_delivery_execution_api.py::test_executor_sends_to_durable_receiver_and_replays_one_verified_receipttests/integration/test_delivery_execution_api.py::test_recreated_sessions_recover_stale_reservation_and_block_ambiguous_sendtests/integration/test_delivery_execution_api.py::test_sqlite_raw_evidence_mutations_are_rejected_after_durable_executiontests/integration/test_delivery_execution_api.py::test_two_sessions_cancel_after_send_start_records_one_unknown_attempttests/integration/test_delivery_execution_api.py::test_two_sessions_cancel_before_send_start_prevents_post_and_resulttests/integration/test_delivery_execution_api.py::test_two_sessions_concurrent_execute_posts_once_and_replays_finaltests/integration/test_delivery_execution_identifier_race.py::test_empty_execution_table_claim_race_preserves_one_result_and_stable_replaytests/integration/test_delivery_execution_identifier_race.py::test_executor_roundtrip_preserves_raw_operation_and_claim_identifiers

create_spacesignature changedbackend/services/browser_space_service.py:232

2 callers outside this PR.

backend/api/v1/browser_spaces.py::create_browser_spacetests/unit/test_browser_space_service.py::_space

execute_tasksignature changedbackend/services/browser_space_service.py:560

2 callers outside this PR, 2 inside it.

tests/unit/test_browser_space_service.py::test_cross_process_cancellation_waits_for_runtime_cleanuptests/unit/test_browser_space_service.py::test_runtime_timeout_finishes_task_as_failed

highprimitive obsession

backend/api/v1/studio_workflows.py:475

_start_published_version_run takes 13 parameters

highprimitive obsession

backend/services/browser_space_service.py:416

submit_task takes 10 parameters

highprimitive obsession

backend/services/browser_space_service.py:232

create_space takes 9 parameters

mediumnested complexity

backend/services/browser_space_service.py:416

submit_task nests 4 levels deep

mediumcomplex method

frontend/app/(app)/control/odp-state/page.tsx:72

OdpStatePage has cyclomatic complexity 14

mediumcomplex method

backend/api/v1/chat.py:594

_chat_with_client has cyclomatic complexity 14

mediumcomplex method

backend/api/v1/chat.py:259

_create_durable_run has cyclomatic complexity 14

mediumcomplex method

backend/workflow/delivery_execution.py:287

_claim has cyclomatic complexity 10

mediumlarge method

backend/services/browser_space_service.py:560

execute_task is 91 lines long

mediumlarge method

backend/services/browser_space_service.py:416

submit_task is 105 lines long

mediumprimitive obsession

backend/api/v1/studio_workflows.py:913

get_project_workflow_evidence_projection takes 8 parameters

mediumprimitive obsession

backend/api/v1/studio_workflows.py:819

list_project_workflow_run_events takes 7 parameters

mediumprimitive obsession

backend/api/v1/studio_workflows.py:604

start_published_workflow_run_from_question_bank takes 8 parameters

mediumprimitive obsession

backend/api/v1/studio_workflows.py:560

start_published_workflow_run takes 7 parameters

mediumprimitive obsession

backend/services/browser_space_service.py:560

execute_task takes 7 parameters

lowlarge method

frontend/app/(app)/control/odp-state/page.tsx:72

OdpStatePage is 63 lines long

lowdry violation

backend/api/v1/studio_workflows.py:844

14% of file duplicated; worst clone shares 27 lines with backend/api/v1/studio_workflows.py

lowdry violation

backend/migrations/versions/bc3d4e5f6a7b_schedule_bound_automations.py:28

11% of file duplicated; worst clone shares 8 lines with backend/migrations/versions/bc3d4e5f6a7b_schedule_bound_automations.py

lowbumpy road

backend/services/browser_space_service.py:560

execute_task has 3 nested blocks at the same level (bumpy road)

lowbumpy road

backend/services/browser_space_service.py:416

submit_task has 3 nested blocks at the same level (bumpy road)

lowlarge method

frontend/components/flow/workflow-editor-session.tsx:95

useCallback callback is 61 lines long

lowerror handling

backend/channels/doubao_research_channel.py:372

broad `except Exception` catches unrelated errors and can hide bugs

lowerror handling

backend/api/v1/chat.py:858

broad `except Exception` catches unrelated errors and can hide bugs

lowerror handling

backend/api/v1/chat.py:876

broad `except Exception` catches unrelated errors and can hide bugs

lowbumpy road

backend/workflow/delivery_execution.py:392

execute_delivery has 3 nested blocks at the same level (bumpy road)

lowlarge method

backend/api/v1/studio_workflows.py:604

start_published_workflow_run_from_question_bank is 65 lines long

lowlarge method

backend/api/v1/studio_workflows.py:475

_start_published_version_run is 60 lines long

lowlarge method

backend/services/browser_space_service.py:232

create_space is 62 lines long

lowprimitive obsession

backend/api/v1/studio_workflows.py:885

get_project_workflow_evidence_batch takes 6 parameters

lowprimitive obsession

backend/api/v1/studio_workflows.py:795

get_project_workflow_run_projection takes 5 parameters

lowprimitive obsession

backend/api/v1/studio_workflows.py:361

_get_project_workflow_run takes 5 parameters

Resolved (1)

complex method
frontend/components/shell/global-agent-dock.tsx

tests/integration/test_auth_api.py

tests/integration/test_presets_api.py

tests/integration/test_record_graph_api.py

tests/integration/test_delivery_authorization_api.py

tests/integration/test_evidence_batch_materialization_api.py

tests/integration/test_dashboard_api.py

tests/integration/test_image_studio_api.py

tests/integration/test_notifications_api.py

tests/integration/test_dataflow_triggering_api.py

tests/integration/test_tasks_api.py

tests/skills/test_execute_loop_live.py

tests/unit/security/test_identity.py

tests/unit/test_workflow_rss_source_executor.py

tests/unit/api/test_automation_starters.py

tests/integration/test_provider_models_api.py

tests/integration/test_auth_ws.py

tests/unit/api/test_nodes_upsert.py

tests/unit/test_migration_heads.py

tests/integration/test_delivery_execution_api.py

tests/integration/test_delivery_execution_identifier_race.py

tests/integration/test_delivery_execution_migration_guards.py

tests/unit/test_browser_space_service.py

tests/integration/test_dataflow_operator_pipeline_api.py

tests/integration/test_generic_webhook_live.py

tests/integration/test_studio_bootstrap_api.py

tests/integration/test_studio_lifecycle_api.py

7 changed files have no test importing them.

Blast radius on the repo map

Every file in the repository, grouped into its own directories and sized by lines. The ones this PR changes are lit, and everything that imports them is marked.

changed, health fellchanged, health rosechanged, health heldimports a changed fileuntouchedchanged by this PR

Drawing 1,673 of 1,834 files at a readable size, grouped by directory and sized by lines of code. 10 changed here reach 50 more by import. 161 are too small to see at this width, which is what the frame below is for.

Inside backend

696 files, 6 changed by this PR and 39 that import one. This PR changes 8 files in total, spread across more than one top-level directory. Click any directory above to frame it instead.

Changed